Remove the requirement for CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTED for NVLS support#489
Merged
Binyang2014 merged 7 commits intomainfrom Mar 28, 2025
Merged
Remove the requirement for CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTED for NVLS support#489Binyang2014 merged 7 commits intomainfrom
CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTED for NVLS support#489Binyang2014 merged 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the outdated requirement for manually setting up IMEX channels (using CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTED) and updates the documentation to state that GPUs with NVLS support now require kernel version 5.6 or above.
- Removed manual IMEX channel setup instructions
- Updated GPU support details to include a kernel version requirement
Files not reviewed (5)
- include/mscclpp/gpu.hpp: Language not supported
- include/mscclpp/gpu_utils.hpp: Language not supported
- src/gpu_utils.cc: Language not supported
- src/include/registered_memory.hpp: Language not supported
- src/registered_memory.cc: Language not supported
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
chhwang
approved these changes
Mar 28, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
chhwang
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the requirement for
CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTEDfor NVLS support.Fix #487